RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:07:45 +00:00
Code Issues Activity Actions

ProfileViewer: Convert the JSON samples into a more efficient format

Browse source 
Only do the conversion from JSON once. This makes it much faster to do
time range filtering with the timeline widget. :^)
This commit is contained in:
Andreas Kling 2019-12-15 17:26:54 +01:00
parent d4a570d576
commit 063fef312e
3 changed files with 48 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

25
DevTools/ProfileViewer/Profile.h
View file

@ -82,20 +82,19 @@ public:
const Vector<NonnullRefPtr<ProfileNode>>& roots() const { return m_roots; }
template<typename Callback>
void for_each_sample(Callback callback)
{
m_json.for_each([&](auto& value) {
callback(value.as_object());
});
}
struct SampleData {
u64 timestamp { 0 };
bool in_kernel { false };
struct Frame {
String symbol;
u32 address { 0 };
u32 offset { 0 };
};
const Vector<SampleData>& sample_data() const { return m_sample_data; }
struct Sample {
u64 timestamp { 0 };
bool in_kernel { false };
Vector<Frame> frames;
};
const Vector<Sample>& samples() const { return m_samples; }
u64 length_in_ms() const { return m_last_timestamp - m_first_timestamp; }
u64 first_timestamp() const { return m_first_timestamp; }
@ -116,7 +115,7 @@ private:
u64 m_first_timestamp { 0 };
u64 m_last_timestamp { 0 };
Vector<SampleData> m_sample_data;
Vector<Sample> m_samples;
bool m_has_timestamp_filter_range { false };
u64 m_timestamp_filter_range_start { 0 };