From 0678ac265cb6d040b703425238488571df849f3e Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Tue, 31 Aug 2021 22:15:44 -0700 Subject: [PATCH] Kernel: Pass InodeMetadata by reference in TmpFSInode::create This struct is non-trivially large, it makes sense to pass it by reference instead of by value in the factory method. Found by Sonar Cloud. --- Kernel/FileSystem/TmpFS.cpp | 4 ++-- Kernel/FileSystem/TmpFS.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Kernel/FileSystem/TmpFS.cpp b/Kernel/FileSystem/TmpFS.cpp index 1f8454dd1c..7fd8b54276 100644 --- a/Kernel/FileSystem/TmpFS.cpp +++ b/Kernel/FileSystem/TmpFS.cpp @@ -72,7 +72,7 @@ RefPtr TmpFS::get_inode(InodeIdentifier identifier) const return it->value; } -TmpFSInode::TmpFSInode(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent) +TmpFSInode::TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent) : Inode(fs, fs.next_inode_index()) , m_metadata(metadata) , m_parent(parent) @@ -84,7 +84,7 @@ TmpFSInode::~TmpFSInode() { } -RefPtr TmpFSInode::create(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent) +RefPtr TmpFSInode::create(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent) { auto inode = adopt_ref_if_nonnull(new (nothrow) TmpFSInode(fs, metadata, parent)); if (inode) diff --git a/Kernel/FileSystem/TmpFS.h b/Kernel/FileSystem/TmpFS.h index bc84dbcbf2..3364a51578 100644 --- a/Kernel/FileSystem/TmpFS.h +++ b/Kernel/FileSystem/TmpFS.h @@ -70,8 +70,8 @@ public: virtual void one_ref_left() override; private: - TmpFSInode(TmpFS& fs, InodeMetadata metadata, InodeIdentifier parent); - static RefPtr create(TmpFS&, InodeMetadata metadata, InodeIdentifier parent); + TmpFSInode(TmpFS& fs, const InodeMetadata& metadata, InodeIdentifier parent); + static RefPtr create(TmpFS&, const InodeMetadata& metadata, InodeIdentifier parent); static RefPtr create_root(TmpFS&); void notify_watchers();