From 067c2346ed0df4102a498f488d2a9c0005e8d1a6 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Thu, 15 Jul 2021 23:48:59 +0100 Subject: [PATCH] LibJS: Implement Temporal.Duration.prototype.hours --- .../Libraries/LibJS/Runtime/CommonPropertyNames.h | 1 + .../LibJS/Runtime/Temporal/DurationPrototype.cpp | 14 ++++++++++++++ .../LibJS/Runtime/Temporal/DurationPrototype.h | 1 + .../Temporal/Duration/Duration.prototype.hours.js | 14 ++++++++++++++ 4 files changed, 30 insertions(+) create mode 100644 Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.hours.js diff --git a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h index e179e07271..9f0fab4efd 100644 --- a/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h +++ b/Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h @@ -197,6 +197,7 @@ namespace JS { P(hasIndices) \ P(hasOwn) \ P(hasOwnProperty) \ + P(hours) \ P(hypot) \ P(id) \ P(ignoreCase) \ diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp index 46ff9bf5bb..ae8495e715 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp @@ -29,6 +29,7 @@ void DurationPrototype::initialize(GlobalObject& global_object) define_native_accessor(vm.names.months, months_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.weeks, weeks_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.days, days_getter, {}, Attribute::Configurable); + define_native_accessor(vm.names.hours, hours_getter, {}, Attribute::Configurable); } static Duration* typed_this(GlobalObject& global_object) @@ -96,4 +97,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::days_getter) return Value(duration->days()); } +// 7.3.7 get Temporal.Duration.prototype.hours, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.hours +JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::hours_getter) +{ + // 1. Let duration be the this value. + // 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]). + auto* duration = typed_this(global_object); + if (vm.exception()) + return {}; + + // 3. Return duration.[[Hours]]. + return Value(duration->hours()); +} + } diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h index e5a07849e6..946bb53d6a 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h @@ -23,6 +23,7 @@ private: JS_DECLARE_NATIVE_FUNCTION(months_getter); JS_DECLARE_NATIVE_FUNCTION(weeks_getter); JS_DECLARE_NATIVE_FUNCTION(days_getter); + JS_DECLARE_NATIVE_FUNCTION(hours_getter); }; } diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.hours.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.hours.js new file mode 100644 index 0000000000..38b4a18c94 --- /dev/null +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.hours.js @@ -0,0 +1,14 @@ +describe("correct behavior", () => { + test("basic functionality", () => { + const duration = new Temporal.Duration(0, 0, 0, 0, 123); + expect(duration.hours).toBe(123); + }); +}); + +test("errors", () => { + test("this value must be a Temporal.Duration object", () => { + expect(() => { + Reflect.get(Temporal.Duration.prototype, "hours", "foo"); + }).toThrowWithMessage(TypeError, "Not a Temporal.Duration"); + }); +});