RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 10:44:58 +00:00
Code Issues Activity Actions

LibWeb: Don't create HTMLInputElement's UA shadow tree for buttons

Browse source 
We don't need an internal editable text node inside buttons. :^)
This commit is contained in:
Andreas Kling 2022-03-16 00:25:28 +01:00
parent b8ee4dfda8
commit 06ccc45157
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -159,7 +159,19 @@ void HTMLInputElement::create_shadow_tree_if_needed()
if (shadow_root())
return;
// FIXME: This assumes that we want a text box. Is that always true?
// FIXME: This could be better factored. Everything except the below types becomes a text input.
switch (type_state()) {
case TypeAttributeState::RadioButton:
case TypeAttributeState::Checkbox:
case TypeAttributeState::Button:
case TypeAttributeState::SubmitButton:
case TypeAttributeState::ResetButton:
case TypeAttributeState::ImageButton:
return;
default:
break;
}
auto shadow_root = adopt_ref(*new DOM::ShadowRoot(document(), *this));
auto initial_value = attribute(HTML::AttributeNames::value);
if (initial_value.is_null())