RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:37:34 +00:00
Code Issues Activity Actions

LibWeb: Boxes that establish FFC or GFC should avoid overlapping floats

Browse source 
Before, we only ensured that boxes establishing BFC did not overlap
with floats because that is what CSS 2.2 specification says. However,
we should also apply the same for boxes establishing FFC or GFC as this
aligns with the behavior of other browsers.

Fixes https://github.com/SerenityOS/serenity/issues/21095
This commit is contained in:
Aliaksandr Kalenik 2023-09-22 15:33:25 +02:00 • committed by Andreas Kling
parent 1cfaadec02
commit 06d05b3c55
6 changed files with 83 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Tests/LibWeb/Layout/expected/block-and-inline/flex-container-should-avoid-overlapping-floats.txt Normal file
View file

@ -0,0 +1,23 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x66 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 400x50 children: not-inline
BlockContainer <div.right> at (370.890625,8) content-size 37.109375x17.46875 floating [BFC] children: inline
line 0 width: 37.109375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [370.890625,8 37.109375x17.46875]
"right"
TextNode <#text>
Box <div.flex> at (8,8) content-size 362.890625x50 flex-container(row) [FFC] children: not-inline
BlockContainer <div.item> at (8,8) content-size 32.34375x50 flex-item [BFC] children: inline
line 0 width: 32.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [8,8 32.34375x17.46875]
"item"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x66]
PaintableWithLines (BlockContainer<BODY>) [8,8 400x50]
PaintableWithLines (BlockContainer<DIV>.right) [370.890625,8 37.109375x17.46875]
TextPaintable (TextNode<#text>)
PaintableBox (Box<DIV>.flex) [8,8 362.890625x50]
PaintableWithLines (BlockContainer<DIV>.item) [8,8 32.34375x50]
TextPaintable (TextNode<#text>)

16
Tests/LibWeb/Layout/expected/block-and-inline/grid-container-should-avoid-overlapping-floats.txt Normal file
View file

@ -0,0 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x66 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 400x50 children: not-inline
BlockContainer <div.right> at (370.890625,8) content-size 37.109375x17.46875 floating [BFC] children: inline
line 0 width: 37.109375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [370.890625,8 37.109375x17.46875]
"right"
TextNode <#text>
Box <div.grid> at (8,8) content-size 362.890625x50 [GFC] children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x66]
PaintableWithLines (BlockContainer<BODY>) [8,8 400x50]
PaintableWithLines (BlockContainer<DIV>.right) [370.890625,8 37.109375x17.46875]
TextPaintable (TextNode<#text>)
PaintableBox (Box<DIV>.grid) [8,8 362.890625x50]