RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

LibWeb: Boxes that establish FFC or GFC should avoid overlapping floats

Browse source 
Before, we only ensured that boxes establishing BFC did not overlap
with floats because that is what CSS 2.2 specification says. However,
we should also apply the same for boxes establishing FFC or GFC as this
aligns with the behavior of other browsers.

Fixes https://github.com/SerenityOS/serenity/issues/21095
This commit is contained in:
Aliaksandr Kalenik 2023-09-22 15:33:25 +02:00 • committed by Andreas Kling
parent 1cfaadec02
commit 06d05b3c55
6 changed files with 83 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -117,6 +117,19 @@ void BlockFormattingContext::parent_context_did_dimension_child_root_box()
}
}
bool BlockFormattingContext::box_should_avoid_floats_because_it_establishes_fc(Box const& box)
{
if (auto formatting_context_type = formatting_context_type_created_by_box(box); formatting_context_type.has_value()) {
if (formatting_context_type.value() == Type::Block)
return true;
if (formatting_context_type.value() == Type::Flex)
return true;
if (formatting_context_type.value() == Type::Grid)
return true;
}
return false;
}
void BlockFormattingContext::compute_width(Box const& box, AvailableSpace const& available_space, LayoutMode)
{
if (box.is_absolutely_positioned()) {
@ -125,7 +138,9 @@ void BlockFormattingContext::compute_width(Box const& box, AvailableSpace const&
}
auto remaining_available_space = available_space;
if (available_space.width.is_definite() && creates_block_formatting_context(box)) {
if (available_space.width.is_definite() && box_should_avoid_floats_because_it_establishes_fc(box)) {
// NOTE: Although CSS 2.2 specification says that only block formatting contexts should avoid floats,
// we also do this for flex and grid formatting contexts, because that how other engines behave.
// 9.5 Floats
// The border box of a table, a block-level replaced element, or an element in the normal flow that establishes a
// new block formatting context (such as an element with 'overflow' other than 'visible') must not overlap the margin