RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

GModel: Rename on_model_update(GModel&) => on_update()

Browse source 
Just simplifying the API of this hook a little bit.
This commit is contained in:
Andreas Kling 2019-08-20 19:45:08 +02:00
parent f7dce05c82
commit 076827a05d
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/FileManager/DirectoryView.cpp
View file

@ -58,7 +58,7 @@ DirectoryView::DirectoryView(GWidget* parent)
m_item_view->set_model_column(GDirectoryModel::Column::Name); m_item_view->set_model_column(GDirectoryModel::Column::Name);
m_table_view->model()->on_model_update = [this](auto&) { m_table_view->model()->on_update = [this] {
set_status_message(String::format("%d item%s (%u byte%s)", set_status_message(String::format("%d item%s (%u byte%s)",
model().row_count(), model().row_count(),
model().row_count() != 1 ? "s" : "", model().row_count() != 1 ? "s" : "",

4
Libraries/LibGUI/GModel.cpp
View file

@ -27,8 +27,8 @@ void GModel::for_each_view(Function<void(GAbstractView&)> callback)
void GModel::did_update() void GModel::did_update()
{ {
if (on_model_update) if (on_update)
on_model_update(*this); on_update();
for_each_view([](auto& view) { for_each_view([](auto& view) {
view.did_update_model(); view.did_update_model();
}); });

2
Libraries/LibGUI/GModel.h
View file

@ -67,7 +67,7 @@ public:
void register_view(Badge<GAbstractView>, GAbstractView&); void register_view(Badge<GAbstractView>, GAbstractView&);
void unregister_view(Badge<GAbstractView>, GAbstractView&); void unregister_view(Badge<GAbstractView>, GAbstractView&);
Function<void(GModel&)> on_model_update; Function<void()> on_update;
Function<void(const GModelIndex&)> on_selection_changed; Function<void(const GModelIndex&)> on_selection_changed;
protected: protected:

2
Libraries/LibGUI/GSortingProxyModel.cpp
View file

@ -7,7 +7,7 @@ GSortingProxyModel::GSortingProxyModel(NonnullRefPtr<GModel>&& target)
: m_target(move(target)) : m_target(move(target))
, m_key_column(-1) , m_key_column(-1)
{ {
m_target->on_model_update = [this](GModel&) { m_target->on_update = [this] {
resort(); resort();
}; };
} }