RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

LibGemini: Propagate OOM errors from GeminiRequest::to_raw_request()

Browse source
This commit is contained in:
Linus Groh 2023-03-09 14:51:48 +00:00
parent d0ecd81888
commit 077f7d1577
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibGemini/GeminiRequest.cpp
View file

@ -10,12 +10,12 @@
namespace Gemini { namespace Gemini {
ByteBuffer GeminiRequest::to_raw_request() const ErrorOr<ByteBuffer> GeminiRequest::to_raw_request() const
{ {
StringBuilder builder; StringBuilder builder;
builder.append(m_url.to_deprecated_string()); TRY(builder.try_append(m_url.to_deprecated_string()));
builder.append("\r\n"sv); TRY(builder.try_append("\r\n"sv));
return builder.to_byte_buffer(); return builder.try_to_byte_buffer();
} }
Optional<GeminiRequest> GeminiRequest::from_raw_request(ByteBuffer const& raw_request) Optional<GeminiRequest> GeminiRequest::from_raw_request(ByteBuffer const& raw_request)

2
Userland/Libraries/LibGemini/GeminiRequest.h
View file

@ -21,7 +21,7 @@ public:
const URL& url() const { return m_url; } const URL& url() const { return m_url; }
void set_url(const URL& url) { m_url = url; } void set_url(const URL& url) { m_url = url; }
ByteBuffer to_raw_request() const; ErrorOr<ByteBuffer> to_raw_request() const;
static Optional<GeminiRequest> from_raw_request(ByteBuffer const&); static Optional<GeminiRequest> from_raw_request(ByteBuffer const&);

2
Userland/Libraries/LibGemini/Job.cpp
View file

@ -111,7 +111,7 @@ void Job::flush_received_buffers()
void Job::on_socket_connected() void Job::on_socket_connected()
{ {
auto raw_request = m_request.to_raw_request(); auto raw_request = m_request.to_raw_request().release_value_but_fixme_should_propagate_errors();
if constexpr (JOB_DEBUG) { if constexpr (JOB_DEBUG) {
dbgln("Job: raw_request:"); dbgln("Job: raw_request:");