RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:37:35 +00:00
Code Issues Activity Actions

LibWeb: Use floats instead of doubles for CSS numbers

Browse source 
Using doubles isn't necessary, and they make things slightly bigger and
slower, so let's use floats instead.
This commit is contained in:
Sam Atkins 2022-03-21 17:22:05 +00:00 • committed by Andreas Kling
parent 1f5b5d3f99
commit 0795b9f7bb
6 changed files with 33 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/CSS/Parser/Token.h
View file

@ -118,7 +118,7 @@ public:
VERIFY(m_type == Type::Number);
return m_value.view();
}
double number_value() const
float number_value() const
{
VERIFY(m_type == Type::Number);
return m_number_value;
@ -135,14 +135,14 @@ public:
VERIFY(m_type == Type::Dimension);
return m_unit.view();
}
double dimension_value() const
float dimension_value() const
{
VERIFY(m_type == Type::Dimension);
return m_number_value;
}
i64 dimension_value_int() const { return to_closest_integer(dimension_value()); }
double percentage() const
float percentage() const
{
VERIFY(m_type == Type::Percentage);
return m_number_value;
@ -165,22 +165,22 @@ public:
Position const& end_position() const { return m_end_position; }
private:
static i64 to_closest_integer(double value)
static i64 to_closest_integer(float value)
{
// https://www.w3.org/TR/css-values-4/#numeric-types
// When a value cannot be explicitly supported due to range/precision limitations, it must be converted
// to the closest value supported by the implementation, but how the implementation defines "closest"
// is explicitly undefined as well.
return llround(value);
return llroundf(value);
}
Type m_type { Type::Invalid };
FlyString m_value;
FlyString m_unit;
HashType m_hash_type { HashType::Unrestricted };
float m_number_value { 0 };
NumberType m_number_type { NumberType::Integer };
double m_number_value { 0 };
HashType m_hash_type { HashType::Unrestricted };
Position m_start_position;
Position m_end_position;