RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:37:44 +00:00
Code Issues Activity Actions

LibGfx: Add a FIXME to ICC encode_tag_data()

Browse source
This commit is contained in:
Nico Weber 2023-02-18 22:02:21 -05:00 • committed by Jelle Raaijmakers
parent 7e769c7217
commit 07bf2d944c
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGfx/ICC/BinaryWriter.cpp
View file

@ -293,6 +293,10 @@ static ErrorOr<ByteBuffer> encode_tag_data(TagData const& tag_data)
case XYZTagData::Type: case XYZTagData::Type:
return encode_xyz(static_cast<XYZTagData const&>(tag_data)); return encode_xyz(static_cast<XYZTagData const&>(tag_data));
} }
// FIXME: If this gets hit, we always write an invalid icc output file.
// Make this return an Optional and don't write tags that have types we can't encode.
// Not ideal, but better than writing invalid outputs.
return ByteBuffer {}; return ByteBuffer {};
} }