RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:07:35 +00:00
Code Issues Activity Actions

LibWeb: Display error page when document parsing fails

Browse source
This commit is contained in:
Idan Horowitz 2023-11-17 15:10:07 +02:00 • committed by Andreas Kling
parent 079c96376c
commit 07ea3ab306
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/DOM/DocumentLoading.cpp
View file

@ -17,6 +17,7 @@
#include <LibWeb/HTML/NavigationParams.h> #include <LibWeb/HTML/NavigationParams.h>
#include <LibWeb/HTML/Parser/HTMLEncodingDetection.h> #include <LibWeb/HTML/Parser/HTMLEncodingDetection.h>
#include <LibWeb/HTML/Parser/HTMLParser.h> #include <LibWeb/HTML/Parser/HTMLParser.h>
#include <LibWeb/Loader/GeneratedPagesLoader.h>
#include <LibWeb/Namespace.h> #include <LibWeb/Namespace.h>
#include <LibWeb/Platform/ImageCodecPlugin.h> #include <LibWeb/Platform/ImageCodecPlugin.h>
#include <LibWeb/XML/XMLDocumentBuilder.h> #include <LibWeb/XML/XMLDocumentBuilder.h>
@ -263,10 +264,14 @@ JS::GCPtr<DOM::Document> load_document(Optional<HTML::NavigationParams> navigati
auto& realm = document->realm(); auto& realm = document->realm();
if (navigation_params->response->body()) { if (navigation_params->response->body()) {
auto process_body = [document](ByteBuffer bytes) { auto process_body = [document, url = navigation_params->response->url().value()](ByteBuffer bytes) {
if (!parse_document(*document, bytes)) { if (parse_document(*document, bytes))
dbgln("FIXME: Load html page with an error if parsing failed."); return;
} document->remove_all_children(true);
auto error_html = load_error_page(url).release_value_but_fixme_should_propagate_errors();
auto parser = HTML::HTMLParser::create(document, error_html, "utf-8");
document->set_url(AK::URL("about:error"));
parser->run();
}; };
auto process_body_error = [](auto) { auto process_body_error = [](auto) {