RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

GWindow: Only flip the window backing stores once per paint event.

Browse source
This commit is contained in:
Andreas Kling 2019-05-21 21:05:10 +02:00
parent 9aa9454c6b
commit 08228f34b9
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
LibGUI/GWindow.cpp
View file

@ -226,13 +226,12 @@ void GWindow::event(CEvent& event)
rects.append({ { }, paint_event.window_size() }); rects.append({ { }, paint_event.window_size() });
} }
for (auto& rect : rects) { for (auto& rect : rects)
m_main_widget->event(*make<GPaintEvent>(rect)); m_main_widget->event(*make<GPaintEvent>(rect));
if (m_double_buffering_enabled)
flip(rect);
}
if (!m_double_buffering_enabled && created_new_backing_store) if (m_double_buffering_enabled)
flip(rects);
else if (created_new_backing_store)
set_current_backing_bitmap(*m_back_bitmap, true); set_current_backing_bitmap(*m_back_bitmap, true);
if (m_window_id) { if (m_window_id) {
@ -451,7 +450,7 @@ void GWindow::set_current_backing_bitmap(GraphicsBitmap& bitmap, bool flush_imme
GEventLoop::current().sync_request(message, WSAPI_ServerMessage::Type::DidSetWindowBackingStore); GEventLoop::current().sync_request(message, WSAPI_ServerMessage::Type::DidSetWindowBackingStore);
} }
void GWindow::flip(const Rect& dirty_rect) void GWindow::flip(const Vector<Rect, 32>& dirty_rects)
{ {
swap(m_front_bitmap, m_back_bitmap); swap(m_front_bitmap, m_back_bitmap);
@ -465,7 +464,8 @@ void GWindow::flip(const Rect& dirty_rect)
// Copy whatever was painted from the front to the back. // Copy whatever was painted from the front to the back.
Painter painter(*m_back_bitmap); Painter painter(*m_back_bitmap);
painter.blit(dirty_rect.location(), *m_front_bitmap, dirty_rect); for (auto& dirty_rect : dirty_rects)
painter.blit(dirty_rect.location(), *m_front_bitmap, dirty_rect);
} }
Retained<GraphicsBitmap> GWindow::create_backing_bitmap(const Size& size) Retained<GraphicsBitmap> GWindow::create_backing_bitmap(const Size& size)

2
LibGUI/GWindow.h
View file

@ -128,7 +128,7 @@ private:
Retained<GraphicsBitmap> create_backing_bitmap(const Size&); Retained<GraphicsBitmap> create_backing_bitmap(const Size&);
void set_current_backing_bitmap(GraphicsBitmap&, bool flush_immediately = false); void set_current_backing_bitmap(GraphicsBitmap&, bool flush_immediately = false);
void flip(const Rect& dirty_rect); void flip(const Vector<Rect, 32>& dirty_rects);
RetainPtr<GraphicsBitmap> m_front_bitmap; RetainPtr<GraphicsBitmap> m_front_bitmap;
RetainPtr<GraphicsBitmap> m_back_bitmap; RetainPtr<GraphicsBitmap> m_back_bitmap;