RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibJS: Take PropertyName in Object::set_integrity_level() internal lambda

Browse source 
At least for IntegrityLevel::Frozen we already construct a PropertyName
from the key value, let's reuse that.
This commit is contained in:
Linus Groh 2021-04-20 09:00:11 +02:00
parent 29fd75f22f
commit 085816645f
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -164,8 +164,7 @@ bool Object::prevent_extensions()
bool Object::set_integrity_level(IntegrityLevel level) bool Object::set_integrity_level(IntegrityLevel level)
{ {
// FIXME: This feels clunky and should get nicer abstractions. // FIXME: This feels clunky and should get nicer abstractions.
auto update_property = [this](auto& key, auto attributes) { auto update_property = [this](auto& property_name, auto attributes) {
auto property_name = PropertyName::from_value(global_object(), key);
auto metadata = shape().lookup(property_name.to_string_or_symbol()); auto metadata = shape().lookup(property_name.to_string_or_symbol());
VERIFY(metadata.has_value()); VERIFY(metadata.has_value());
auto value = get_direct(metadata->offset); auto value = get_direct(metadata->offset);
@ -184,7 +183,8 @@ bool Object::set_integrity_level(IntegrityLevel level)
switch (level) { switch (level) {
case IntegrityLevel::Sealed: case IntegrityLevel::Sealed:
for (auto& key : keys) { for (auto& key : keys) {
update_property(key, ~Attribute::Configurable); auto property_name = PropertyName::from_value(global_object(), key);
update_property(property_name, ~Attribute::Configurable);
if (vm.exception()) if (vm.exception())
return {}; return {};
} }
@ -197,7 +197,7 @@ bool Object::set_integrity_level(IntegrityLevel level)
u8 attributes = property_descriptor->is_accessor_descriptor() u8 attributes = property_descriptor->is_accessor_descriptor()
? ~Attribute::Configurable ? ~Attribute::Configurable
: ~Attribute::Configurable & ~Attribute::Writable; : ~Attribute::Configurable & ~Attribute::Writable;
update_property(key, attributes); update_property(property_name, attributes);
if (vm.exception()) if (vm.exception())
return {}; return {};
} }