RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 18:22:45 +00:00
Code Issues Activity Actions

Everywhere: Use 'decrease_slider_by()' method from AbstractSlider

Browse source 
The same idea as 'increase_slider_by()', it helps us to avoid repeating
the pattern 'set_value(value() - delta)'.
This commit is contained in:
Elyse 2021-10-31 12:27:52 -06:00 • committed by Andreas Kling
parent d53e1fa1fa
commit 086615535f
8 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PDFViewer/PDFViewer.cpp
View file

@ -106,7 +106,7 @@ void PDFViewer::mousewheel_event(GUI::MouseEvent& event)
scrollbar.set_value(scrollbar.max()); scrollbar.set_value(scrollbar.max());
} }
} else { } else {
scrollbar.set_value(scrollbar.value() - 20); scrollbar.decrease_slider_by(20);
} }
} }
} }

4
Userland/Applications/PixelPaint/Tools/Tool.cpp
View file

@ -34,7 +34,7 @@ void Tool::on_keydown(GUI::KeyEvent& event)
switch (event.key()) { switch (event.key()) {
case KeyCode::Key_LeftBracket: case KeyCode::Key_LeftBracket:
if (m_primary_slider) if (m_primary_slider)
m_primary_slider->set_value(m_primary_slider->value() - 1); m_primary_slider->decrease_slider_by(1);
break; break;
case KeyCode::Key_RightBracket: case KeyCode::Key_RightBracket:
if (m_primary_slider) if (m_primary_slider)
@ -42,7 +42,7 @@ void Tool::on_keydown(GUI::KeyEvent& event)
break; break;
case KeyCode::Key_LeftBrace: case KeyCode::Key_LeftBrace:
if (m_secondary_slider) if (m_secondary_slider)
m_secondary_slider->set_value(m_secondary_slider->value() - 1); m_secondary_slider->decrease_slider_by(1);
break; break;
case KeyCode::Key_RightBrace: case KeyCode::Key_RightBrace:
if (m_secondary_slider) if (m_secondary_slider)

2
Userland/Libraries/LibGUI/OpacitySlider.cpp
View file

@ -139,7 +139,7 @@ void OpacitySlider::mouseup_event(MouseEvent& event)
void OpacitySlider::mousewheel_event(MouseEvent& event) void OpacitySlider::mousewheel_event(MouseEvent& event)
{ {
set_value(value() - event.wheel_delta()); decrease_slider_by(event.wheel_delta());
} }
} }

2
Userland/Libraries/LibGUI/Scrollbar.cpp
View file

@ -329,7 +329,7 @@ void Scrollbar::scroll_by_page(const Gfx::IntPoint& click_position)
if (click_position.primary_offset_for_orientation(orientation()) < scrubber_rect().primary_offset_for_orientation(orientation())) { if (click_position.primary_offset_for_orientation(orientation()) < scrubber_rect().primary_offset_for_orientation(orientation())) {
gutter_click_state = GutterClickState::BeforeScrubber; gutter_click_state = GutterClickState::BeforeScrubber;
set_value(value() - page_increment); decrease_slider_by(page_increment);
} else { } else {
gutter_click_state = GutterClickState::AfterScrubber; gutter_click_state = GutterClickState::AfterScrubber;
increase_slider_by(page_increment); increase_slider_by(page_increment);

2
Userland/Libraries/LibGUI/Slider.cpp
View file

@ -147,7 +147,7 @@ void Slider::mousewheel_event(MouseEvent& event)
wheel_delta /= abs(wheel_delta); wheel_delta /= abs(wheel_delta);
if (orientation() == Orientation::Horizontal) if (orientation() == Orientation::Horizontal)
set_value(value() - wheel_delta * acceleration_modifier); decrease_slider_by(wheel_delta * acceleration_modifier);
else else
increase_slider_by(wheel_delta * acceleration_modifier); increase_slider_by(wheel_delta * acceleration_modifier);

4
Userland/Libraries/LibGUI/ValueSlider.cpp
View file

@ -52,7 +52,7 @@ ValueSlider::ValueSlider(Gfx::Orientation orientation, String suffix)
m_textbox->on_down_pressed = [&]() { m_textbox->on_down_pressed = [&]() {
if (value() > min()) if (value() > min())
AbstractSlider::set_value(value() - 1); AbstractSlider::decrease_slider_by(1);
m_textbox->set_text(formatted_value()); m_textbox->set_text(formatted_value());
}; };
@ -161,7 +161,7 @@ void ValueSlider::mousewheel_event(MouseEvent& event)
if (event.wheel_delta() < 0) if (event.wheel_delta() < 0)
increase_slider_by(1); increase_slider_by(1);
else else
set_value(value() - 1); decrease_slider_by(1);
} }
void ValueSlider::mousemove_event(MouseEvent& event) void ValueSlider::mousemove_event(MouseEvent& event)

2
Userland/Libraries/LibVT/TerminalWidget.cpp
View file

@ -215,7 +215,7 @@ void TerminalWidget::keydown_event(GUI::KeyEvent& event)
m_cursor_blink_timer->start(); m_cursor_blink_timer->start();
if (event.key() == KeyCode::Key_PageUp && event.modifiers() == Mod_Shift) { if (event.key() == KeyCode::Key_PageUp && event.modifiers() == Mod_Shift) {
m_scrollbar->set_value(m_scrollbar->value() - m_terminal.rows()); m_scrollbar->decrease_slider_by(m_terminal.rows());
return; return;
} }
if (event.key() == KeyCode::Key_PageDown && event.modifiers() == Mod_Shift) { if (event.key() == KeyCode::Key_PageDown && event.modifiers() == Mod_Shift) {

2
Userland/Libraries/LibWeb/InProcessWebView.cpp
View file

@ -269,7 +269,7 @@ void InProcessWebView::keydown_event(GUI::KeyEvent& event)
vertical_scrollbar().increase_slider_by(frame_inner_rect().height()); vertical_scrollbar().increase_slider_by(frame_inner_rect().height());
break; break;
case Key_PageUp: case Key_PageUp:
vertical_scrollbar().set_value(vertical_scrollbar().value() - frame_inner_rect().height()); vertical_scrollbar().decrease_slider_by(frame_inner_rect().height());
break; break;
default: default:
if (!page_accepted_event) { if (!page_accepted_event) {