RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

Kernel: Migrate process list locking to ProtectedValue

Browse source 
The existing recursive spinlock is repurposed for profiling only, as it
was shared with the process list.
This commit is contained in:
Jean-Baptiste Boric 2021-07-24 18:43:29 +02:00 • committed by Andreas Kling
parent 8554b66d09
commit 08891e82a5
5 changed files with 76 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Syscalls/kill.cpp
View file

@ -65,8 +65,7 @@ KResult Process::do_killall(int signal)
KResult error = KSuccess;
// Send the signal to all processes we have access to for.
ScopedSpinLock lock(g_processes_lock);
for (auto& process : processes()) {
processes().for_each_shared([&](auto& process) {
KResult res = KSuccess;
if (process.pid() == pid())
res = do_killself(signal);
@ -77,7 +76,7 @@ KResult Process::do_killall(int signal)
any_succeeded = true;
else
error = res;
}
});
if (any_succeeded)
return KSuccess;
@ -117,7 +116,6 @@ KResultOr<FlatPtr> Process::sys$kill(pid_t pid_or_pgid, int signal)
return do_killself(signal);
}
VERIFY(pid_or_pgid >= 0);
ScopedSpinLock lock(g_processes_lock);
auto peer = Process::from_pid(pid_or_pgid);
if (!peer)
return ESRCH;