RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:02:46 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Fix some inconsistencies in NativeFunction callbacks

Browse source 
These should always pass the arguments in a const Vector<JS::Value>&.
This commit is contained in:
Andreas Kling 2020-03-21 14:43:44 +01:00
parent 324b92fd06
commit 08b17d70af
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Bindings/DocumentWrapper.cpp
View file

@ -36,7 +36,7 @@ namespace Bindings {
DocumentWrapper::DocumentWrapper(Document& document)
: NodeWrapper(document)
{
put_native_function("getElementById", [this](JS::Object*, Vector<JS::Value> arguments) -> JS::Value {
put_native_function("getElementById", [this](JS::Object*, const Vector<JS::Value>& arguments) -> JS::Value {
if (arguments.is_empty())
return JS::js_null();
auto id = arguments[0].to_string();