RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 19:37:34 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Fix some inconsistencies in NativeFunction callbacks

Browse source 
These should always pass the arguments in a const Vector<JS::Value>&.
This commit is contained in:
Andreas Kling 2020-03-21 14:43:44 +01:00
parent 324b92fd06
commit 08b17d70af
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/NativeFunction.h
View file

@ -42,7 +42,7 @@ private:
virtual bool is_native_function() const override { return true; } virtual bool is_native_function() const override { return true; }
virtual const char* class_name() const override { return "NativeFunction"; } virtual const char* class_name() const override { return "NativeFunction"; }
AK::Function<Value(Object*, Vector<Value>)> m_native_function; AK::Function<Value(Object*, const Vector<Value>&)> m_native_function;
}; };
} }

2
Libraries/LibWeb/Bindings/DocumentWrapper.cpp
View file

@ -36,7 +36,7 @@ namespace Bindings {
DocumentWrapper::DocumentWrapper(Document& document) DocumentWrapper::DocumentWrapper(Document& document)
: NodeWrapper(document) : NodeWrapper(document)
{ {
put_native_function("getElementById", [this](JS::Object*, Vector<JS::Value> arguments) -> JS::Value { put_native_function("getElementById", [this](JS::Object*, const Vector<JS::Value>& arguments) -> JS::Value {
if (arguments.is_empty()) if (arguments.is_empty())
return JS::js_null(); return JS::js_null();
auto id = arguments[0].to_string(); auto id = arguments[0].to_string();

2
Libraries/LibWeb/DOM/Document.cpp
View file

@ -341,7 +341,7 @@ JS::Interpreter& Document::interpreter()
if (!m_interpreter) { if (!m_interpreter) {
m_interpreter = make<JS::Interpreter>(); m_interpreter = make<JS::Interpreter>();
m_interpreter->global_object().put_native_function("alert", [](JS::Object*, Vector<JS::Value> arguments) -> JS::Value { m_interpreter->global_object().put_native_function("alert", [](JS::Object*, const Vector<JS::Value>& arguments) -> JS::Value {
if (arguments.size() < 1) if (arguments.size() < 1)
return JS::js_undefined(); return JS::js_undefined();
GUI::MessageBox::show(arguments[0].to_string(), "Alert", GUI::MessageBox::Type::Information); GUI::MessageBox::show(arguments[0].to_string(), "Alert", GUI::MessageBox::Type::Information);