RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 05:27:45 +00:00
Code Issues Activity Actions

WebDriver+Browser: Implement GET /session/{id}/element/{id}/rect

Browse source
This commit is contained in:
Timothy Flynn 2022-11-03 12:53:27 -04:00 • committed by Linus Groh
parent a490bca29b
commit 08c687ef20
9 changed files with 68 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/BrowserWindow.cpp
View file

@ -631,6 +631,10 @@ void BrowserWindow::create_new_tab(URL url, bool activate)
return active_tab().view().get_element_tag_name(element_id);
};
new_tab.webdriver_endpoints().on_get_element_rect = [this](i32 element_id) {
return active_tab().view().get_element_rect(element_id);
};
new_tab.webdriver_endpoints().on_serialize_source = [this]() {
return active_tab().view().serialize_source();
};

11
Userland/Applications/Browser/WebDriverConnection.cpp
View file

@ -283,6 +283,17 @@ Messages::WebDriverSessionClient::GetElementTagNameResponse WebDriverConnection:
return { "" };
}
Messages::WebDriverSessionClient::GetElementRectResponse WebDriverConnection::get_element_rect(i32 element_id)
{
dbgln("WebDriverConnection: get_element_rect {}", element_id);
if (auto browser_window = m_browser_window.strong_ref()) {
auto& tab = browser_window->active_tab();
if (tab.webdriver_endpoints().on_get_element_rect)
return { tab.webdriver_endpoints().on_get_element_rect(element_id) };
}
return { {} };
}
Messages::WebDriverSessionClient::TakeScreenshotResponse WebDriverConnection::take_screenshot()
{
dbgln_if(WEBDRIVER_DEBUG, "WebDriverConnection: take_screenshot");

1
Userland/Applications/Browser/WebDriverConnection.h
View file

@ -63,6 +63,7 @@ public:
virtual Messages::WebDriverSessionClient::GetComputedValueForElementResponse get_computed_value_for_element(i32 element_id, String const& property_name) override;
virtual Messages::WebDriverSessionClient::GetElementTextResponse get_element_text(i32 element_id) override;
virtual Messages::WebDriverSessionClient::GetElementTagNameResponse get_element_tag_name(i32 element_id) override;
virtual Messages::WebDriverSessionClient::GetElementRectResponse get_element_rect(i32 element_id) override;
virtual Messages::WebDriverSessionClient::TakeScreenshotResponse take_screenshot() override;
private:

2
Userland/Applications/Browser/WebDriverEndpoints.h
View file

@ -8,6 +8,7 @@
#include <AK/Forward.h>
#include <AK/Function.h>
#include <LibGfx/Rect.h>
#include <LibWeb/Forward.h>
namespace Messages::WebContentServer {
@ -29,6 +30,7 @@ public:
Function<String(i32 element_id, String const&)> on_get_computed_value_for_element;
Function<String(i32 element_id)> on_get_element_text;
Function<String(i32 element_id)> on_get_element_tag_name;
Function<Gfx::IntRect(i32 element_id)> on_get_element_rect;
Function<String()> on_serialize_source;
Function<Messages::WebContentServer::WebdriverExecuteScriptResponse(String const& body, Vector<String> const& json_arguments, Optional<u64> const& timeout, bool async)> on_execute_script;
};

1
Userland/Applications/Browser/WebDriverSessionClient.ipc
View file

@ -37,5 +37,6 @@ endpoint WebDriverSessionClient {
get_computed_value_for_element(i32 element_id, String property_name) => (String computed_value)
get_element_text(i32 element_id) => (String text)
get_element_tag_name(i32 element_id) => (String tag_name)
get_element_rect(i32 element_id) => (Gfx::IntRect rect)
take_screenshot() => (Gfx::ShareableBitmap data)
}