RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:17:36 +00:00
Code Issues Activity Actions

Kernel: Rename FileDescriptor to FileDescription.

Browse source 
After reading a bunch of POSIX specs, I've learned that a file descriptor
is the number that refers to a file description, not the description itself.
So this patch renames FileDescriptor to FileDescription, and Process now has
FileDescription* file_description(int fd).
This commit is contained in:
Andreas Kling 2019-06-07 09:36:51 +02:00
parent 69a6ce90df
commit 08cd75ac4b
70 changed files with 373 additions and 373 deletions
Download patch file Download diff file Expand all files Collapse all files

4
LibCore/CFile.cpp
View file

@ -10,11 +10,11 @@ CFile::CFile(const StringView& filename)
CFile::~CFile()
{
if (m_should_close_file_descriptor == ShouldCloseFileDescriptor::Yes && mode() != NotOpen)
if (m_should_close_file_descriptor == ShouldCloseFileDescription::Yes && mode() != NotOpen)
close();
}
bool CFile::open(int fd, CIODevice::OpenMode mode, ShouldCloseFileDescriptor should_close)
bool CFile::open(int fd, CIODevice::OpenMode mode, ShouldCloseFileDescription should_close)
{
set_fd(fd);
set_mode(mode);

6
LibCore/CFile.h
View file

@ -14,16 +14,16 @@ public:
virtual bool open(CIODevice::OpenMode) override;
enum class ShouldCloseFileDescriptor
enum class ShouldCloseFileDescription
{
No = 0,
Yes
};
bool open(int fd, CIODevice::OpenMode, ShouldCloseFileDescriptor);
bool open(int fd, CIODevice::OpenMode, ShouldCloseFileDescription);
virtual const char* class_name() const override { return "CFile"; }
private:
String m_filename;
ShouldCloseFileDescriptor m_should_close_file_descriptor { ShouldCloseFileDescriptor::Yes };
ShouldCloseFileDescription m_should_close_file_descriptor { ShouldCloseFileDescription::Yes };
};