From 08d79c757a13c88f5525737e74aa62431d6459e7 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 3 Apr 2023 18:40:53 +0200 Subject: [PATCH] Kernel: Mark sys$killpg as not needing the big lock Same as sys$kill, nothing here that isn't already protected by existing locks. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/kill.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index f87259a7ae..1e80efc73e 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -117,7 +117,7 @@ enum class NeedsBigProcessLock { S(jail_attach, NeedsBigProcessLock::No) \ S(kill, NeedsBigProcessLock::No) \ S(kill_thread, NeedsBigProcessLock::Yes) \ - S(killpg, NeedsBigProcessLock::Yes) \ + S(killpg, NeedsBigProcessLock::No) \ S(link, NeedsBigProcessLock::No) \ S(listen, NeedsBigProcessLock::No) \ S(lseek, NeedsBigProcessLock::No) \ diff --git a/Kernel/Syscalls/kill.cpp b/Kernel/Syscalls/kill.cpp index d9ba3b3d50..fe94832ee4 100644 --- a/Kernel/Syscalls/kill.cpp +++ b/Kernel/Syscalls/kill.cpp @@ -134,7 +134,7 @@ ErrorOr Process::sys$kill(pid_t pid_or_pgid, int signal) ErrorOr Process::sys$killpg(pid_t pgrp, int signum) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::proc)); if (signum < 1 || signum >= 32) return EINVAL;