RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:37:46 +00:00
Code Issues Activity Actions

LibJS: Convert BooleanPrototype functions to ThrowCompletionOr

Browse source
This commit is contained in:
Idan Horowitz 2021-10-29 00:41:04 +03:00
parent 2a0c51149d
commit 08fb31087b
2 changed files with 10 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibJS/Runtime/BooleanPrototype.cpp
View file

@ -22,8 +22,8 @@ void BooleanPrototype::initialize(GlobalObject& global_object)
auto& vm = this->vm(); auto& vm = this->vm();
BooleanObject::initialize(global_object); BooleanObject::initialize(global_object);
u8 attr = Attribute::Writable | Attribute::Configurable; u8 attr = Attribute::Writable | Attribute::Configurable;
define_old_native_function(vm.names.toString, to_string, 0, attr); define_native_function(vm.names.toString, to_string, 0, attr);
define_old_native_function(vm.names.valueOf, value_of, 0, attr); define_native_function(vm.names.valueOf, value_of, 0, attr);
} }
BooleanPrototype::~BooleanPrototype() BooleanPrototype::~BooleanPrototype()
@ -31,30 +31,26 @@ BooleanPrototype::~BooleanPrototype()
} }
// 20.3.3.2 Boolean.prototype.toString ( ), https://tc39.es/ecma262/#sec-boolean.prototype.tostring // 20.3.3.2 Boolean.prototype.toString ( ), https://tc39.es/ecma262/#sec-boolean.prototype.tostring
JS_DEFINE_OLD_NATIVE_FUNCTION(BooleanPrototype::to_string) JS_DEFINE_NATIVE_FUNCTION(BooleanPrototype::to_string)
{ {
auto this_value = vm.this_value(global_object); auto this_value = vm.this_value(global_object);
if (this_value.is_boolean()) if (this_value.is_boolean())
return js_string(vm, this_value.as_bool() ? "true" : "false"); return js_string(vm, this_value.as_bool() ? "true" : "false");
if (!this_value.is_object() || !is<BooleanObject>(this_value.as_object())) { if (!this_value.is_object() || !is<BooleanObject>(this_value.as_object()))
vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Boolean"); return vm.throw_completion<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Boolean");
return {};
}
bool bool_value = static_cast<const BooleanObject&>(this_value.as_object()).value_of().as_bool(); bool bool_value = static_cast<const BooleanObject&>(this_value.as_object()).value_of().as_bool();
return js_string(vm, bool_value ? "true" : "false"); return js_string(vm, bool_value ? "true" : "false");
} }
// 20.3.3.3 Boolean.prototype.valueOf ( ), https://tc39.es/ecma262/#sec-boolean.prototype.valueof // 20.3.3.3 Boolean.prototype.valueOf ( ), https://tc39.es/ecma262/#sec-boolean.prototype.valueof
JS_DEFINE_OLD_NATIVE_FUNCTION(BooleanPrototype::value_of) JS_DEFINE_NATIVE_FUNCTION(BooleanPrototype::value_of)
{ {
auto this_value = vm.this_value(global_object); auto this_value = vm.this_value(global_object);
if (this_value.is_boolean()) if (this_value.is_boolean())
return this_value; return this_value;
if (!this_value.is_object() || !is<BooleanObject>(this_value.as_object())) { if (!this_value.is_object() || !is<BooleanObject>(this_value.as_object()))
vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Boolean"); return vm.throw_completion<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Boolean");
return {};
}
return static_cast<const BooleanObject&>(this_value.as_object()).value_of(); return static_cast<const BooleanObject&>(this_value.as_object()).value_of();
} }

4
Userland/Libraries/LibJS/Runtime/BooleanPrototype.h
View file

@ -19,8 +19,8 @@ public:
virtual ~BooleanPrototype() override; virtual ~BooleanPrototype() override;
private: private:
JS_DECLARE_OLD_NATIVE_FUNCTION(to_string); JS_DECLARE_NATIVE_FUNCTION(to_string);
JS_DECLARE_OLD_NATIVE_FUNCTION(value_of); JS_DECLARE_NATIVE_FUNCTION(value_of);
}; };
} }