RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:38:10 +00:00
Code Issues Activity Actions

Revert "LibWeb: Allow bypassing transient activation checks for tests"

Browse source 
This reverts commit e52c30cbd5.

It's highly possible that this test was flaky on CI due to mixing units
of seconds and milliseconds in the transient activation calculation.
Revert the workaround for that commit in an attempt to avoid needless
ad-hoc behavior.
This commit is contained in:
Timothy Flynn 2024-02-24 16:28:53 -05:00 • committed by Tim Flynn
parent 8d7a5afe58
commit 090dbac5a3
6 changed files with 14 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -134,7 +134,6 @@ void Window::visit_edges(JS::Cell::Visitor& visitor)
visitor.visit(mime_type_object);
visitor.visit(m_count_queuing_strategy_size_function);
visitor.visit(m_byte_length_queuing_strategy_size_function);
visitor.visit(m_internals);
}
void Window::finalize()
@ -606,14 +605,6 @@ bool Window::has_transient_activation() const
// perceive the link between an interaction with the page and the page calling the activation-gated API.
static constexpr HighResolutionTime::DOMHighResTimeStamp transient_activation_duration_ms = 5000;
// AD-HOC: Due to resource limitations on CI, we cannot rely on the time between the activation timestamp and the
// transient activation timeout being predictable. So we allow tests to indicate when they want the next
// check for a user gesture to succeed.
if (m_internals && m_internals->bypass_next_transient_activation_test()) {
m_internals->set_bypass_next_transient_activation_test(false);
return true;
}
// When the current high resolution time given W
auto unsafe_shared_time = HighResolutionTime::unsafe_shared_current_time();
auto current_time = HighResolutionTime::relative_high_resolution_time(unsafe_shared_time, realm().global_object());
@ -822,11 +813,8 @@ WebIDL::ExceptionOr<void> Window::initialize_web_interfaces(Badge<WindowEnvironm
if (s_inspector_object_exposed)
define_direct_property("inspector", heap().allocate<Internals::Inspector>(realm, realm), JS::default_attributes);
if (s_internals_object_exposed) {
m_internals = heap().allocate<Internals::Internals>(realm, realm);
define_direct_property("internals", m_internals, JS::default_attributes);
}
if (s_internals_object_exposed)
define_direct_property("internals", heap().allocate<Internals::Internals>(realm, realm), JS::default_attributes);
return {};
}