RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

Revert "LibWeb: Allow bypassing transient activation checks for tests"

Browse source 
This reverts commit e52c30cbd5.

It's highly possible that this test was flaky on CI due to mixing units
of seconds and milliseconds in the transient activation calculation.
Revert the workaround for that commit in an attempt to avoid needless
ad-hoc behavior.
This commit is contained in:
Timothy Flynn 2024-02-24 16:28:53 -05:00 • committed by Tim Flynn
parent 8d7a5afe58
commit 090dbac5a3
6 changed files with 14 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Internals/Internals.h
View file

@ -28,14 +28,11 @@ public:
void click(double x, double y);
void wheel(double x, double y, double delta_x, double delta_y);
bool bypass_next_transient_activation_test() const { return m_bypass_next_transient_activation_test; }
void set_bypass_next_transient_activation_test(bool bypass_next_transient_activation_test) { m_bypass_next_transient_activation_test = bypass_next_transient_activation_test; }
WebIDL::ExceptionOr<bool> dispatch_user_activated_event(DOM::EventTarget&, DOM::Event& event);
private:
explicit Internals(JS::Realm&);
virtual void initialize(JS::Realm&) override;
bool m_bypass_next_transient_activation_test { false };
};
}