RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:57:35 +00:00
Code Issues Activity Actions

LibWeb: Remove more DeprecatedString null state remnants

Browse source
This commit is contained in:
Ali Mohammad Pur 2023-10-13 22:50:34 +03:30 • committed by Tim Flynn
parent 988c6568a9
commit 0937d88869
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1963,7 +1963,7 @@ DeprecatedString Document::cookie(Cookie::Source source)
{ {
if (auto* page = this->page()) if (auto* page = this->page())
return page->client().page_did_request_cookie(m_url, source); return page->client().page_did_request_cookie(m_url, source);
return {}; return DeprecatedString::empty();
} }
void Document::set_cookie(StringView cookie_string, Cookie::Source source) void Document::set_cookie(StringView cookie_string, Cookie::Source source)

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -150,7 +150,7 @@ DeprecatedString Element::deprecated_get_attribute(StringView name) const
{ {
auto maybe_attribute = get_attribute(name); auto maybe_attribute = get_attribute(name);
if (!maybe_attribute.has_value()) if (!maybe_attribute.has_value())
return {}; return DeprecatedString::empty();
return maybe_attribute->to_deprecated_string(); return maybe_attribute->to_deprecated_string();
} }

6
Userland/Libraries/LibWeb/DOM/ParentNode.cpp
View file

@ -170,9 +170,9 @@ JS::NonnullGCPtr<HTMLCollection> ParentNode::get_elements_by_tag_name_ns(Depreca
auto local_name = MUST(FlyString::from_deprecated_fly_string(deprecated_local_name)); auto local_name = MUST(FlyString::from_deprecated_fly_string(deprecated_local_name));
// 1. If namespace is the empty string, set it to null. // 1. If namespace is the empty string, set it to null.
DeprecatedString namespace_ = nullable_namespace; DeprecatedFlyString namespace_;
if (namespace_.is_empty()) if (!nullable_namespace.is_null() && !nullable_namespace.is_empty())
namespace_ = {}; namespace_ = nullable_namespace;
// 2. If both namespace and localName are "*" (U+002A), return a HTMLCollection rooted at root, whose filter matches descendant elements. // 2. If both namespace and localName are "*" (U+002A), return a HTMLCollection rooted at root, whose filter matches descendant elements.
if (namespace_ == "*" && local_name == "*") { if (namespace_ == "*" && local_name == "*") {

4
Userland/Libraries/LibWeb/HTML/FormAssociatedElement.cpp
View file

@ -102,9 +102,9 @@ void FormAssociatedElement::reset_form_owner()
// 4. If element is listed, has a form content attribute, and is connected, then: // 4. If element is listed, has a form content attribute, and is connected, then:
if (is_listed() && html_element.has_attribute(HTML::AttributeNames::form) && html_element.is_connected()) { if (is_listed() && html_element.has_attribute(HTML::AttributeNames::form) && html_element.is_connected()) {
// 1. If the first element in element's tree, in tree order, to have an ID that is identical to element's form content attribute's value, is a form element, then associate the element with that form element. // 1. If the first element in element's tree, in tree order, to have an ID that is identical to element's form content attribute's value, is a form element, then associate the element with that form element.
auto form_value = html_element.deprecated_attribute(HTML::AttributeNames::form); auto form_value = html_element.attribute(HTML::AttributeNames::form);
html_element.root().for_each_in_inclusive_subtree_of_type<HTMLFormElement>([this, &form_value](HTMLFormElement& form_element) { html_element.root().for_each_in_inclusive_subtree_of_type<HTMLFormElement>([this, &form_value](HTMLFormElement& form_element) {
if (form_element.deprecated_attribute(HTML::AttributeNames::id) == form_value) { if (form_element.attribute(HTML::AttributeNames::id) == form_value) {
set_form(&form_element); set_form(&form_element);
return IterationDecision::Break; return IterationDecision::Break;
} }