RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibManual: Error on section_number 0 instead of crashing

Browse source 
Prior to this commit if you tried to access section 0 of the man page
(`man 0 ls`) the application would just crash with an array out of
bounds style error.

This commit just ensures that we return an explicit and helpful error
message when you try to request the 0th section, instead of crashing.
This commit is contained in:
Carwyn Nelson 2023-07-03 21:02:49 +01:00 • committed by Jelle Raaijmakers
parent 0eb09a0b59
commit 093cbcd606
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibManual/SectionNode.cpp
View file

@ -22,8 +22,8 @@ ErrorOr<NonnullRefPtr<SectionNode>> SectionNode::try_create_from_number(StringVi
if (!maybe_section_number.has_value())
return Error::from_string_literal("Section is not a number");
auto section_number = maybe_section_number.release_value();
if (section_number > number_of_sections)
return Error::from_string_literal("Section number too large");
if (section_number < 1 || section_number > number_of_sections)
return Error::from_string_literal("Section number is not valid");
return sections[section_number - 1];
}