RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-09-17 21:46:16 +00:00
Code Issues Activity Actions

LibVideo/VP9: Use an enum to select segment features

Browse source 
This throws out some ugly `#define`s we had that were taking the role
of an enum anyway. We now have some nice getters in the contexts that
take the place of the combo of `seg_feature_active()` and then doing a
lookup in `FrameContext::m_segmentation_features` directly.
This commit is contained in:
Zaggy1024 2023-04-16 23:29:48 -05:00 • committed by Tim Flynn
parent 6e6cc1ddb2
commit 094b0d8a78
8 changed files with 46 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibVideo/VP9/Context.h
View file

@ -143,7 +143,11 @@ public:
bool use_predicted_segment_id_tree { false };
Array<u8, 3> predicted_segment_id_tree_probabilities;
bool should_use_absolute_segment_base_quantizer { false };
Array<Array<SegmentFeature, SEG_LVL_MAX>, MAX_SEGMENTS> segmentation_features;
SegmentationFeatures segmentation_features;
SegmentFeatureStatus get_segment_feature(u8 segment_id, SegmentFeature feature) const
{
return segmentation_features[segment_id][to_underlying(feature)];
}
u16 header_size_in_bytes { 0 };
@ -334,6 +338,11 @@ struct BlockContext {
SegmentationPredictionContextView above_segmentation_ids;
NonZeroTokensView left_non_zero_tokens;
SegmentationPredictionContextView left_segmentation_ids;
SegmentFeatureStatus get_segment_feature(SegmentFeature feature) const
{
return frame_context.get_segment_feature(segment_id, feature);
}
};
struct BlockMotionVectorCandidateSet {