RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

LibJS: Fix typo in LHS Object and RHS BigInt loosely equals check

Browse source 
Step 12 was using `lhs.is_bigint()` instead of `rhs.is_bigint()`,
meaning you got:
```js
1n == Object(1n); // true
Object(1n) == 1n; // false
```

This also adds spec comments to is_loosely_equal.
This commit is contained in:
Luke Wilde 2021-10-15 01:47:54 +01:00 • committed by Linus Groh
parent 3ad159537e
commit 09536f5f48
2 changed files with 45 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibJS/Tests/builtins/BigInt/bigint-basic.js
View file

@ -73,6 +73,21 @@ describe("correct behavior", () => {
const b = 704179908449526267977309288010258n;
expect(a == a).toBeTrue();
expect(a == b).toBeFalse();
expect(0n == Object(0n)).toBeTrue();
expect(Object(0n) == 0n).toBeTrue();
expect(0n != Object(0n)).toBeFalse();
expect(Object(0n) != 0n).toBeFalse();
expect(1n == Object(1n)).toBeTrue();
expect(Object(1n) == 1n).toBeTrue();
expect(1n != Object(1n)).toBeFalse();
expect(Object(1n) != 1n).toBeFalse();
expect(1n == Object(2n)).toBeFalse();
expect(Object(2n) == 1n).toBeFalse();
expect(1n != Object(2n)).toBeTrue();
expect(Object(2n) != 1n).toBeTrue();
});
test("strong equality operators", () => {