RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:57:44 +00:00
Code Issues Activity Actions

LibJS: Add a bunch of fast_is<T> to avoid slow RTTI in hot code

Browse source
This commit is contained in:
Andreas Kling 2021-06-13 11:23:23 +02:00
parent 39ad705c13
commit 095accd2b2
5 changed files with 61 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/LexicalEnvironment.h
View file

@ -66,6 +66,7 @@ public:
EnvironmentRecordType type() const { return m_environment_record_type; }
private:
virtual bool is_lexical_environment() const override { return true; }
virtual void visit_edges(Visitor&) override;
EnvironmentRecordType m_environment_record_type : 8 { EnvironmentRecordType::Declarative };
@ -78,4 +79,7 @@ private:
Function* m_current_function { nullptr };
};
template<>
inline bool Object::fast_is<LexicalEnvironment>() const { return is_lexical_environment(); }
}

4
Userland/Libraries/LibJS/Runtime/NativeFunction.h
View file

@ -35,9 +35,13 @@ protected:
private:
virtual LexicalEnvironment* create_environment() override final;
virtual bool is_native_function() const final { return true; }
FlyString m_name;
AK::Function<Value(VM&, GlobalObject&)> m_native_function;
};
template<>
inline bool Object::fast_is<NativeFunction>() const { return is_native_function(); }
}

3
Userland/Libraries/LibJS/Runtime/Object.h
View file

@ -106,6 +106,9 @@ public:
virtual bool is_typed_array() const { return false; }
virtual bool is_string_object() const { return false; }
virtual bool is_global_object() const { return false; }
virtual bool is_proxy_object() const { return false; }
virtual bool is_native_function() const { return false; }
virtual bool is_lexical_environment() const { return false; }
virtual const char* class_name() const override { return "Object"; }
virtual void visit_edges(Cell::Visitor&) override;

4
Userland/Libraries/LibJS/Runtime/ProxyObject.h
View file

@ -46,10 +46,14 @@ private:
virtual void visit_edges(Visitor&) override;
virtual bool is_function() const override { return m_target.is_function(); }
virtual bool is_proxy_object() const final { return true; }
Object& m_target;
Object& m_handler;
bool m_is_revoked { false };
};
template<>
inline bool Object::fast_is<ProxyObject>() const { return is_proxy_object(); }
}