RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 05:48:12 +00:00
Code Issues Activity Actions

LibGUI: Convert ItemListModel's Display Role to string during search

Browse source 
Previously, you could get crashes when you tried to search for a font
size in the Font Picker or a screen resolution in Display Settings.

This is because their list models aren't made of strings
and Variant::as_string() only accepts strings.
This commit is contained in:
Karol Kosek 2021-10-16 23:35:41 +02:00 • committed by Andreas Kling
parent c55527944c
commit 097902bd06
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/ItemListModel.h
View file

@ -85,7 +85,7 @@ public:
for (auto it = m_data.begin(); it != m_data.end(); ++it) {
for (auto it2d = (*it).begin(); it2d != (*it).end(); ++it2d) {
GUI::ModelIndex index = this->index(it.index(), it2d.index());
if (!string_matches(data(index, ModelRole::Display).as_string(), searching, flags))
if (!string_matches(data(index, ModelRole::Display).to_string(), searching, flags))
continue;
found_indices.append(index);
@ -96,7 +96,7 @@ public:
} else {
for (auto it = m_data.begin(); it != m_data.end(); ++it) {
GUI::ModelIndex index = this->index(it.index());
if (!string_matches(data(index, ModelRole::Display).as_string(), searching, flags))
if (!string_matches(data(index, ModelRole::Display).to_string(), searching, flags))
continue;
found_indices.append(index);