From 09c1eccb50ec27cd9588b2238d860a32d19a6826 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Wed, 4 Oct 2023 18:14:48 +0200 Subject: [PATCH] LibWeb: Fix crash in XMLHttpRequest::response_xml() if response empty If response object is empty we should return nullptr. Fixes crash on https://store.steampowered.com/ --- Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp b/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp index 75149cb73b..1dde00f7f2 100644 --- a/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp +++ b/Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp @@ -144,6 +144,8 @@ WebIDL::ExceptionOr> XMLHttpRequest::response_xml() set_document_response(); // 6. Return this’s response object. + if (m_response_object.has()) + return nullptr; return &verify_cast(m_response_object.get().as_object()); }