RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:28:10 +00:00
Code Issues Activity Actions

LibGfx: Use ErrorOr<T> for Bitmap infrastructure used by ShareableBitmap

Browse source 
This also allows us to get rid of the ShareableBitmap(Bitmap)
constructor which was easy to misuse. Everyone now uses Bitmap's
to_shareable_bitmap() helper instead.
This commit is contained in:
Andreas Kling 2021-11-06 13:15:43 +01:00
parent 8262bbf624
commit 09cba7c780
5 changed files with 13 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/InProcessWebView.cpp
View file

@ -119,8 +119,8 @@ void InProcessWebView::page_did_request_image_context_menu(const Gfx::IntPoint&
return;
Gfx::ShareableBitmap shareable_bitmap;
if (bitmap)
shareable_bitmap = Gfx::ShareableBitmap(*bitmap);
on_image_context_menu_request(url, screen_relative_rect().location().translated(to_widget_position(content_position)), shareable_bitmap);
shareable_bitmap = bitmap->to_shareable_bitmap();
on_image_context_menu_request(url, screen_relative_rect().location().translated(to_widget_position(content_position)), move(shareable_bitmap));
}
void InProcessWebView::page_did_click_link(const AK::URL& url, const String& target, unsigned modifiers)