RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibJS: Handle Object.prototype.hasOwnProperty() with no arg correctly

Browse source 
I.e. the same as hasOwnProperty(undefined) or
hasOwnProperty("undefined") :^)
This commit is contained in:
Linus Groh 2020-04-28 18:59:38 +01:00 • committed by Andreas Kling
parent 4419685b7e
commit 0a0ba64383
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/ObjectPrototype.cpp
View file

@ -57,8 +57,6 @@ Value ObjectPrototype::has_own_property(Interpreter& interpreter)
auto* this_object = interpreter.this_value().to_object(interpreter.heap()); auto* this_object = interpreter.this_value().to_object(interpreter.heap());
if (!this_object) if (!this_object)
return {}; return {};
if (!interpreter.argument_count())
return {};
return Value(this_object->has_own_property(interpreter.argument(0).to_string())); return Value(this_object->has_own_property(interpreter.argument(0).to_string()));
} }

6
Libraries/LibJS/Tests/Object.prototype.hasOwnProperty.js
View file

@ -5,6 +5,12 @@ try {
o.foo = 1; o.foo = 1;
assert(o.hasOwnProperty("foo") === true); assert(o.hasOwnProperty("foo") === true);
assert(o.hasOwnProperty("bar") === false); assert(o.hasOwnProperty("bar") === false);
assert(o.hasOwnProperty() === false);
assert(o.hasOwnProperty(undefined) === false);
o.undefined = 2;
assert(o.hasOwnProperty() === true);
assert(o.hasOwnProperty(undefined) === true);
console.log("PASS"); console.log("PASS");
} catch (e) { } catch (e) {
console.log("FAIL: " + e); console.log("FAIL: " + e);