RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

LibWeb: Move gap tracks initialization into separate method in GFC

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-05-09 18:38:53 +03:00 • committed by Andreas Kling
parent 62d26a5afb
commit 0a1bffdd92
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -610,7 +610,10 @@ void GridFormattingContext::initialize_grid_tracks(AvailableSpace const& availab
m_grid_columns.append(TemporaryTrack()); m_grid_columns.append(TemporaryTrack());
for (int row_index = m_grid_rows.size(); row_index < m_occupation_grid.row_count(); row_index++) for (int row_index = m_grid_rows.size(); row_index < m_occupation_grid.row_count(); row_index++)
m_grid_rows.append(TemporaryTrack()); m_grid_rows.append(TemporaryTrack());
}
void GridFormattingContext::initialize_gap_tracks(AvailableSpace const& available_space)
{
// https://www.w3.org/TR/css-grid-2/#gutters // https://www.w3.org/TR/css-grid-2/#gutters
// 11.1. Gutters: the row-gap, column-gap, and gap properties // 11.1. Gutters: the row-gap, column-gap, and gap properties
// For the purpose of track sizing, each gutter is treated as an extra, empty, fixed-size track of // For the purpose of track sizing, each gutter is treated as an extra, empty, fixed-size track of
@ -1337,6 +1340,8 @@ void GridFormattingContext::run(Box const& box, LayoutMode, AvailableSpace const
// The grid sizing algorithm defines how to resolve these sizing constraints into used track sizes. // The grid sizing algorithm defines how to resolve these sizing constraints into used track sizes.
initialize_grid_tracks(available_space); initialize_grid_tracks(available_space);
initialize_gap_tracks(available_space);
// https://www.w3.org/TR/css-grid-2/#algo-overview // https://www.w3.org/TR/css-grid-2/#algo-overview
// 12.1. Grid Sizing Algorithm // 12.1. Grid Sizing Algorithm

1
Userland/Libraries/LibWeb/Layout/GridFormattingContext.h
View file

@ -163,6 +163,7 @@ private:
void place_item_with_no_declared_position(Box const& child_box, int& auto_placement_cursor_x, int& auto_placement_cursor_y); void place_item_with_no_declared_position(Box const& child_box, int& auto_placement_cursor_x, int& auto_placement_cursor_y);
void initialize_grid_tracks(AvailableSpace const&); void initialize_grid_tracks(AvailableSpace const&);
void initialize_gap_tracks(AvailableSpace const&);
void run_track_sizing(GridDimension const dimension, AvailableSpace const& available_space, Vector<TemporaryTrack>& tracks); void run_track_sizing(GridDimension const dimension, AvailableSpace const& available_space, Vector<TemporaryTrack>& tracks);
CSSPixels content_based_minimum_height(GridItem const&); CSSPixels content_based_minimum_height(GridItem const&);