RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 17:05:07 +00:00
Code Issues Activity Actions

Ladybird: Fix some crashes related to keyboard events

Browse source 
Don't try to get the unicode value of an empty string.
This commit is contained in:
Diego Iastrubni 2022-09-14 21:35:42 +03:00 • committed by Andrew Kaster
parent ef757f33da
commit 0a38d246f9
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Ladybird/WebView.cpp
View file

@ -602,18 +602,25 @@ void WebView::keyPressEvent(QKeyEvent* event)
break; break;
} }
auto text = event->text();
if (text.isEmpty()) {
return;
}
auto point = event->text()[0].unicode();
auto keycode = get_keycode_from_qt_keyboard_event(*event); auto keycode = get_keycode_from_qt_keyboard_event(*event);
auto modifiers = get_modifiers_from_qt_keyboard_event(*event); auto modifiers = get_modifiers_from_qt_keyboard_event(*event);
auto point = event->text()[0].unicode();
// dbgln(String::formatted("keycode={}, modifiers={}, point={}", (int32_t)keycode, modifiers, point));
m_page_client->page().handle_keydown(keycode, modifiers, point); m_page_client->page().handle_keydown(keycode, modifiers, point);
} }
void WebView::keyReleaseEvent(QKeyEvent* event) void WebView::keyReleaseEvent(QKeyEvent* event)
{ {
auto text = event->text();
if (text.isEmpty()) {
return;
}
auto point = event->text()[0].unicode();
auto keycode = get_keycode_from_qt_keyboard_event(*event); auto keycode = get_keycode_from_qt_keyboard_event(*event);
auto modifiers = get_modifiers_from_qt_keyboard_event(*event); auto modifiers = get_modifiers_from_qt_keyboard_event(*event);
auto point = event->text()[0].unicode();
m_page_client->page().handle_keyup(keycode, modifiers, point); m_page_client->page().handle_keyup(keycode, modifiers, point);
} }