RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:28:11 +00:00
Code Issues Activity Actions

LibWeb: Port HTMLHyperlinkElementUtils from DeprecatedString to String

Browse source
This commit is contained in:
Shannon Booth 2023-11-20 13:34:37 +13:00 • committed by Andreas Kling
parent 9888db1c27
commit 0a4586d510
8 changed files with 64 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.cpp
View file

@ -59,11 +59,11 @@ void HTMLAnchorElement::activation_behavior(Web::DOM::Event const&)
// AD-HOC: follow_the_hyperlink currently doesn't navigate properly with javascript urls
// EventHandler::handle_mouseup performs the navigation steps for javascript urls instead
if (href().starts_with("javascript:"sv))
if (href().starts_with_bytes("javascript:"sv))
return;
// 2. Let hyperlinkSuffix be null.
Optional<DeprecatedString> hyperlink_suffix {};
Optional<String> hyperlink_suffix {};
// FIXME: 3. If event's target is an img with an ismap attribute
// specified, then: