From 0a80daef902bbddcfefc77cb26aa89453f1273fe Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Sat, 2 Dec 2023 18:00:40 -0500 Subject: [PATCH] LibGfx/TIFF: Don't include the null-byte terminator when reading strings --- Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp index 95dec18648..a4ee558170 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp @@ -378,6 +378,9 @@ private: case Type::ASCII: case Type::UTF8: { Vector result; + // NOTE: No need to include the null terminator + if (count > 0) + --count; auto string_data = TRY(ByteBuffer::create_uninitialized(count)); TRY(m_stream->read_until_filled(string_data)); result.empend(TRY(String::from_utf8(StringView { string_data.bytes() })));