mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 14:37:45 +00:00
LibAudio: Use ReadonlyBytes instead of Bytes for buffer parameters
Bytes will implicitly cast to StringView, but not to ReadonlyBytes. That means that if you call `Audio::Loader::create_plugin(mapped_file->bytes())` it will silently use the `create_plugin(StringView path)` overload. Reading audio data does not require that data to be writable, so let's use ReadonlyBytes for it and avoid the footgun.
This commit is contained in:
parent
8e0fa57e5b
commit
0a9fa85e86
4 changed files with 5 additions and 4 deletions
|
@ -48,7 +48,7 @@ private:
|
|||
MaybeLoaderError parse_header();
|
||||
MaybeLoaderError load_wav_info_block(Vector<RIFF::Chunk> info_chunks);
|
||||
|
||||
LoaderSamples samples_from_pcm_data(Bytes const& data, size_t samples_to_read) const;
|
||||
LoaderSamples samples_from_pcm_data(ReadonlyBytes data, size_t samples_to_read) const;
|
||||
template<typename SampleReader>
|
||||
MaybeLoaderError read_samples_from_stream(Stream& stream, SampleReader read_sample, FixedArray<Sample>& samples) const;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue