From 0aa375441afbe922210b941ce0537788dfdbd79a Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 4 Nov 2023 16:35:05 -0400 Subject: [PATCH] Browser: Mark the DOM tree as loaded before selecting any DOM node The first thing that `set_selection` does is return early if the DOM- loaded flag is false. Set it to true so it can actually do something. This fixes inspecting a DOM node from the context menu. --- Userland/Applications/Browser/InspectorWidget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Applications/Browser/InspectorWidget.cpp b/Userland/Applications/Browser/InspectorWidget.cpp index 71d3b29092..852b8c7e10 100644 --- a/Userland/Applications/Browser/InspectorWidget.cpp +++ b/Userland/Applications/Browser/InspectorWidget.cpp @@ -138,11 +138,12 @@ void InspectorWidget::select_default_node() void InspectorWidget::set_dom_json(StringView json) { m_dom_tree_view->set_model(WebView::DOMTreeModel::create(json, *m_dom_tree_view)); + m_dom_loaded = true; + if (m_pending_selection.has_value()) set_selection(m_pending_selection.release_value()); else select_default_node(); - m_dom_loaded = true; } void InspectorWidget::clear_dom_json()