From 0aadd4869d971dd582ac39c0c774326379cc47f7 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 9 Sep 2022 09:40:56 -0400 Subject: [PATCH] LibUnicode: Generate emoji data for non-fully-qualified emoji This allows us to find emoji data for files such as /res/emoji/U+A9.png. U+00A9 is not fully-qualified (its full form is U+00A9 U+FE0F). But the UCD has unqualified data for this code point; generating it allows us to categorize these emoji appropriately in the EmojiInputDialog. --- .../Tools/CodeGenerators/LibUnicode/GenerateEmojiData.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateEmojiData.cpp b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateEmojiData.cpp index 667d324c05..3fe2b895e2 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateEmojiData.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateEmojiData.cpp @@ -58,11 +58,6 @@ static ErrorOr parse_emoji_test_data(Core::Stream::BufferedFile& file, Emo auto emoji_and_name_index = line.find('#', *status_index); VERIFY(emoji_and_name_index.has_value()); - // FIXME: Should we keep non-fully-qualified emoji? TR #51 states this is implementation defined. - auto status = line.substring_view(*status_index + 1, *emoji_and_name_index - *status_index - 1).trim_whitespace(); - if (status != "fully-qualified"sv) - continue; - Emoji emoji {}; emoji.group = group; emoji.display_order = display_order++;