RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:17:34 +00:00
Code Issues Activity Actions

Kernel/Storage: Properly free unused NVMeIO AsyncBlockDeviceRequest

Browse source 
This was the root cause of zombie processes showing up randomly and
disappearing after some disk activity, such as running shell commands -
The NVMeIO AsyncBlockDeviceRequest member simply held a pointer to a
Process object, therefore it could keep it alive a for a long time after
it ceased to actually function at all.
This commit is contained in:
Liav A 2023-08-18 13:18:21 +03:00 • committed by Jelle Raaijmakers
parent 65854c3411
commit 0b6424d883
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Devices/Storage/NVMe/NVMeInterruptQueue.cpp
View file

@ -57,7 +57,7 @@ void NVMeInterruptQueue::complete_current_request(u16 cmdid, u16 status)
request_pdu.request->complete(req_result); request_pdu.request->complete(req_result);
if (request_pdu.end_io_handler) if (request_pdu.end_io_handler)
request_pdu.end_io_handler(status); request_pdu.end_io_handler(status);
request_pdu.used = false; request_pdu.clear();
}; };
// There can be submission without any request associated with it such as with // There can be submission without any request associated with it such as with
@ -87,7 +87,7 @@ void NVMeInterruptQueue::complete_current_request(u16 cmdid, u16 status)
current_request->complete(AsyncDeviceRequest::OutOfMemory); current_request->complete(AsyncDeviceRequest::OutOfMemory);
if (request_pdu.end_io_handler) if (request_pdu.end_io_handler)
request_pdu.end_io_handler(status); request_pdu.end_io_handler(status);
request_pdu.used = false; request_pdu.clear();
} }
} }
} }

2
Kernel/Devices/Storage/NVMe/NVMePollQueue.cpp
View file

@ -42,7 +42,7 @@ void NVMePollQueue::complete_current_request(u16 cmdid, u16 status)
request_pdu.request->complete(req_result); request_pdu.request->complete(req_result);
if (request_pdu.end_io_handler) if (request_pdu.end_io_handler)
request_pdu.end_io_handler(status); request_pdu.end_io_handler(status);
request_pdu.used = false; request_pdu.clear();
}; };
// There can be submission without any request associated with it such as with // There can be submission without any request associated with it such as with

6
Kernel/Devices/Storage/NVMe/NVMeQueue.h
View file

@ -34,6 +34,12 @@ enum class QueueType {
class AsyncBlockDeviceRequest; class AsyncBlockDeviceRequest;
struct NVMeIO { struct NVMeIO {
void clear()
{
used = false;
request = nullptr;
end_io_handler = nullptr;
}
RefPtr<AsyncBlockDeviceRequest> request; RefPtr<AsyncBlockDeviceRequest> request;
bool used = false; bool used = false;
Function<void(u16 status)> end_io_handler; Function<void(u16 status)> end_io_handler;