RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 13:37:45 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/Clipboard/ConnectionFromClient.cpp
View file

@ -25,10 +25,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
s_connections.set(client_id, *this);
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
s_connections.remove(client_id());

2
Userland/Services/Clipboard/ConnectionFromClient.h
View file

@ -18,7 +18,7 @@ class ConnectionFromClient final
C_OBJECT(ConnectionFromClient);
public:
virtual ~ConnectionFromClient() override;
virtual ~ConnectionFromClient() override = default;
virtual void die() override;

8
Userland/Services/Clipboard/Storage.cpp
View file

@ -14,14 +14,6 @@ Storage& Storage::the()
return s_the;
}
Storage::Storage()
{
}
Storage::~Storage()
{
}
void Storage::set_data(Core::AnonymousBuffer data, const String& mime_type, const HashMap<String, String>& metadata)
{
m_buffer = move(data);

4
Userland/Services/Clipboard/Storage.h
View file

@ -16,7 +16,7 @@ namespace Clipboard {
class Storage {
public:
static Storage& the();
~Storage();
~Storage() = default;
bool has_data() const { return m_buffer.is_valid(); }
@ -44,7 +44,7 @@ public:
const Core::AnonymousBuffer& buffer() const { return m_buffer; }
private:
Storage();
Storage() = default;
String m_mime_type;
Core::AnonymousBuffer m_buffer;