RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:27:44 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/DHCPClient/DHCPv4Client.cpp
View file

@ -201,10 +201,6 @@ ErrorOr<DHCPv4Client::Interfaces> DHCPv4Client::get_discoverable_interfaces()
};
}
DHCPv4Client::~DHCPv4Client()
{
}
void DHCPv4Client::handle_offer(const DHCPv4Packet& packet, const ParsedDHCPv4Options& options)
{
dbgln("We were offered {} for {}", packet.yiaddr().to_string(), options.get<u32>(DHCPOption::IPAddressLeaseTime).value_or(0));

2
Userland/Services/DHCPClient/DHCPv4Client.h
View file

@ -40,7 +40,7 @@ class DHCPv4Client final : public Core::Object {
C_OBJECT(DHCPv4Client)
public:
virtual ~DHCPv4Client() override;
virtual ~DHCPv4Client() override = default;
void dhcp_discover(const InterfaceDescriptor& ifname);
void dhcp_request(DHCPv4Transaction& transaction, const DHCPv4Packet& packet);