RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:47:34 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/InspectorServer/ConnectionFromClient.cpp
View file

@ -18,10 +18,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
s_connections.set(client_id, *this);
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
s_connections.remove(client_id());

2
Userland/Services/InspectorServer/ConnectionFromClient.h
View file

@ -18,7 +18,7 @@ class ConnectionFromClient final
C_OBJECT(ConnectionFromClient);
public:
~ConnectionFromClient() override;
~ConnectionFromClient() override = default;
virtual void die() override;

4
Userland/Services/InspectorServer/InspectableProcess.cpp
View file

@ -33,10 +33,6 @@ InspectableProcess::InspectableProcess(pid_t pid, NonnullOwnPtr<Core::Stream::Lo
};
}
InspectableProcess::~InspectableProcess()
{
}
String InspectableProcess::wait_for_response()
{
if (m_socket->is_eof()) {

2
Userland/Services/InspectorServer/InspectableProcess.h
View file

@ -13,7 +13,7 @@ namespace InspectorServer {
class InspectableProcess {
public:
InspectableProcess(pid_t, NonnullOwnPtr<Core::Stream::LocalSocket>);
~InspectableProcess();
~InspectableProcess() = default;
void send_request(JsonObject const& request);
String wait_for_response();