RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:57:36 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/LookupServer/ConnectionFromClient.cpp
View file

@ -19,10 +19,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
s_connections.set(client_id, *this);
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
s_connections.remove(client_id());

2
Userland/Services/LookupServer/ConnectionFromClient.h
View file

@ -18,7 +18,7 @@ class ConnectionFromClient final
C_OBJECT(ConnectionFromClient);
public:
virtual ~ConnectionFromClient() override;
virtual ~ConnectionFromClient() override = default;
virtual void die() override;

2
Userland/Services/LookupServer/DNSPacket.cpp
View file

@ -77,7 +77,7 @@ ByteBuffer DNSPacket::to_byte_buffer() const
class [[gnu::packed]] DNSRecordWithoutName {
public:
DNSRecordWithoutName() { }
DNSRecordWithoutName() = default;
u16 type() const { return m_type; }
u16 record_class() const { return m_class; }

2
Userland/Services/LookupServer/DNSPacket.h
View file

@ -22,7 +22,7 @@ enum class ShouldRandomizeCase {
class DNSPacket {
public:
DNSPacket() { }
DNSPacket() = default;
static Optional<DNSPacket> from_raw_packet(const u8*, size_t);
ByteBuffer to_byte_buffer() const;