RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:27:35 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/NotificationServer/ConnectionFromClient.cpp
View file

@ -19,10 +19,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
s_connections.set(client_id, *this);
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
s_connections.remove(client_id());

2
Userland/Services/NotificationServer/ConnectionFromClient.h
View file

@ -18,7 +18,7 @@ namespace NotificationServer {
class ConnectionFromClient final : public IPC::ConnectionFromClient<NotificationClientEndpoint, NotificationServerEndpoint> {
C_OBJECT(ConnectionFromClient)
public:
~ConnectionFromClient() override;
~ConnectionFromClient() override = default;
virtual void die() override;

4
Userland/Services/NotificationServer/NotificationWindow.cpp
View file

@ -98,10 +98,6 @@ NotificationWindow::NotificationWindow(i32 client_id, const String& text, const
};
}
NotificationWindow::~NotificationWindow()
{
}
RefPtr<NotificationWindow> NotificationWindow::get_window_by_id(i32 id)
{
auto window = s_windows.get(id);

2
Userland/Services/NotificationServer/NotificationWindow.h
View file

@ -15,7 +15,7 @@ class NotificationWindow final : public GUI::Window {
C_OBJECT(NotificationWindow);
public:
virtual ~NotificationWindow() override;
virtual ~NotificationWindow() override = default;
void set_original_rect(Gfx::IntRect original_rect) { m_original_rect = original_rect; };
void set_text(const String&);