RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:17:45 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/RequestServer/ConnectionFromClient.cpp
View file

@ -22,10 +22,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
s_connections.set(1, *this);
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
s_connections.remove(client_id());

2
Userland/Services/RequestServer/ConnectionFromClient.h
View file

@ -19,7 +19,7 @@ class ConnectionFromClient final
C_OBJECT(ConnectionFromClient);
public:
~ConnectionFromClient() override;
~ConnectionFromClient() override = default;
virtual void die() override;

4
Userland/Services/RequestServer/GeminiProtocol.cpp
View file

@ -17,10 +17,6 @@ GeminiProtocol::GeminiProtocol()
{
}
GeminiProtocol::~GeminiProtocol()
{
}
OwnPtr<Request> GeminiProtocol::start_request(ConnectionFromClient& client, const String&, const URL& url, const HashMap<String, String>&, ReadonlyBytes)
{
Gemini::GeminiRequest request;

2
Userland/Services/RequestServer/GeminiProtocol.h
View file

@ -13,7 +13,7 @@ namespace RequestServer {
class GeminiProtocol final : public Protocol {
public:
GeminiProtocol();
virtual ~GeminiProtocol() override;
virtual ~GeminiProtocol() override = default;
virtual OwnPtr<Request> start_request(ConnectionFromClient&, const String& method, const URL&, const HashMap<String, String>&, ReadonlyBytes body) override;
};

4
Userland/Services/RequestServer/Request.cpp
View file

@ -19,10 +19,6 @@ Request::Request(ConnectionFromClient& client, NonnullOwnPtr<Core::Stream::File>
{
}
Request::~Request()
{
}
void Request::stop()
{
m_client.did_finish_request({}, *this, false);

2
Userland/Services/RequestServer/Request.h
View file

@ -18,7 +18,7 @@ namespace RequestServer {
class Request {
public:
virtual ~Request();
virtual ~Request() = default;
i32 id() const { return m_id; }
virtual URL url() const = 0;