RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:57:47 +00:00
Code Issues Activity Actions

Services: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-03-23 20:58:03 -06:00 • committed by Brian Gianforcaro
parent 5550905c00
commit 0b7baa7e5a
80 changed files with 50 additions and 202 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -41,10 +41,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
m_paint_flush_timer = Core::Timer::create_single_shot(0, [this] { flush_pending_paint_requests(); });
}
ConnectionFromClient::~ConnectionFromClient()
{
}
void ConnectionFromClient::die()
{
Core::EventLoop::current().quit(0);

2
Userland/Services/WebContent/ConnectionFromClient.h
View file

@ -25,7 +25,7 @@ class ConnectionFromClient final
C_OBJECT(ConnectionFromClient);
public:
~ConnectionFromClient() override;
~ConnectionFromClient() override = default;
virtual void die() override;

4
Userland/Services/WebContent/ConsoleGlobalObject.cpp
View file

@ -19,10 +19,6 @@ ConsoleGlobalObject::ConsoleGlobalObject(Web::Bindings::WindowObject& parent_obj
{
}
ConsoleGlobalObject::~ConsoleGlobalObject()
{
}
void ConsoleGlobalObject::initialize_global_object()
{
Base::initialize_global_object();

2
Userland/Services/WebContent/ConsoleGlobalObject.h
View file

@ -21,7 +21,7 @@ class ConsoleGlobalObject final : public JS::GlobalObject {
public:
ConsoleGlobalObject(Web::Bindings::WindowObject&);
virtual ~ConsoleGlobalObject() override;
virtual ~ConsoleGlobalObject() override = default;
virtual JS::ThrowCompletionOr<Object*> internal_get_prototype_of() const override;
virtual JS::ThrowCompletionOr<bool> internal_set_prototype_of(Object* prototype) override;

4
Userland/Services/WebContent/PageHost.cpp
View file

@ -28,10 +28,6 @@ PageHost::PageHost(ConnectionFromClient& client)
});
}
PageHost::~PageHost()
{
}
void PageHost::set_has_focus(bool has_focus)
{
m_has_focus = has_focus;

2
Userland/Services/WebContent/PageHost.h
View file

@ -19,7 +19,7 @@ class PageHost final : public Web::PageClient {
public:
static NonnullOwnPtr<PageHost> create(ConnectionFromClient& client) { return adopt_own(*new PageHost(client)); }
virtual ~PageHost();
virtual ~PageHost() = default;
Web::Page& page() { return *m_page; }
const Web::Page& page() const { return *m_page; }