RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

LibJS: Remove Object::is_array() in favor of Value::is_array() and RTTI

Browse source 
It's way too easy to get this wrong: for the IsArray abstract operation,
Value::is_array() needs to be called. Since we have RTTI, the virtual
Object::is_array() method is not needed anymore - if we need to know
whether something is *actually* a JS::Array (we currently check in more
cases than we should, I think) and not a Proxy with an Array target, we
should do that in a way that doesn't look like an abstract operation.
This commit is contained in:
Linus Groh 2021-07-05 18:58:51 +01:00
parent 06ffc0c4db
commit 0ba81dc0b7
8 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/js.cpp
View file

@ -452,7 +452,7 @@ static void print_value(JS::Value value, HashTable<JS::Object*>& seen_objects)
if (value.is_object()) {
auto& object = value.as_object();
if (object.is_array())
if (is<JS::Array>(object))
return print_array(static_cast<JS::Array&>(object), seen_objects);
if (object.is_function())
return print_function(object, seen_objects);