RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 18:05:07 +00:00
Code Issues Activity Actions

LibJS: Fix Object::delete_property() with numeric string property

Browse source 
- We have to check if the property name is a string before calling
  as_string() on it
- We can't as_number() the same property name but have to use the parsed
  index number

Fixes #3950.
This commit is contained in:
Linus Groh 2020-11-04 23:31:47 +00:00 • committed by Andreas Kling
parent 8d96f428ef
commit 0bb66890c8
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Tests/operators/delete-basic.js
View file

@ -46,6 +46,9 @@ test("deleting array indices", () => {
expect(a.hasOwnProperty(1)).toBeFalse();
expect(a.hasOwnProperty(2)).toBeFalse();
expect(Object.getOwnPropertyNames(a)).toHaveLength(1);
expect(delete a["42"]).toBeTrue();
expect(Object.getOwnPropertyNames(a)).toHaveLength(1);
});
test("deleting non-configurable property", () => {