RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

LibWeb: Refactor should_skip_anonymous_text_runs

Browse source 
This same function was being copied in the {Flex,Grid}FormattingContext,
so unify them in the parent FormattingContext.
This commit is contained in:
Tom 2022-12-28 10:11:54 +01:00 • committed by Andreas Kling
parent 97dde51a9b
commit 0bbf7a1b54
4 changed files with 21 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -305,19 +305,8 @@ void FlexFormattingContext::generate_anonymous_flex_items()
HashMap<int, Vector<FlexItem>> order_item_bucket;
flex_container().for_each_child_of_type<Box>([&](Box& child_box) {
// Skip anonymous text runs that are only whitespace.
if (child_box.is_anonymous() && !child_box.is_generated() && !child_box.first_child_of_type<BlockContainer>()) {
bool contains_only_white_space = true;
child_box.for_each_in_subtree([&](auto const& node) {
if (!is<TextNode>(node) || !static_cast<TextNode const&>(node).dom_node().data().is_whitespace()) {
contains_only_white_space = false;
return IterationDecision::Break;
}
return IterationDecision::Continue;
});
if (contains_only_white_space)
return IterationDecision::Continue;
}
if (can_skip_is_anonymous_text_run(child_box))
return IterationDecision::Continue;
// Skip any "out-of-flow" children
if (child_box.is_out_of_flow(*this))